Adding SAM 2.1 to the model zoo #4979
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe pull request modifies the logic in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
docs/scripts/make_model_zoo_docs.py (2)
150-161: Enhance documentation clarity for med-sam model usageThe template provides good example code, but could benefit from additional clarity:
- Consider explaining why frame 100 is chosen as the reference frame.
- Add a note about the expected format of
gt_detectionsto help users prepare their data correctly.# Retaining detections from a single frame in the middle # Note that SAM2 only propagates segmentation masks forward in a video + # Note: gt_detections should contain bounding box annotations in COCO format ( dataset .match_frames(F("frame_number") != 100)
161-168: LGTM with a suggestion for documentationThe changes look good and maintain consistency with FiftyOne's field naming conventions. The comment about supporting both Detections and Keypoints is helpful.
Consider adding a brief example of how to use Keypoints as prompts, as this might not be immediately obvious to users:
# Segment inside boxes and propagate to all frames + # Example with keypoints: + # dataset.apply_model(model, label_field="segmentations", prompt_field="frames.keypoints") dataset.apply_model( model, label_field="segmentations", prompt_field="frames.detections", # can contain Detections or Keypoints
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
fiftyone/zoo/models/manifest-torch.jsonis excluded by!**/*.json
📒 Files selected for processing (1)
- docs/scripts/make_model_zoo_docs.py (1 hunks)
brimoor
force-pushed
the
prerna/add-sam2.1-checkpoints
branch
from
641ccba
to
864b692
Compare
What changes are proposed in this pull request?
(Please fill in changes proposed in this fix)
How is this patch tested? If it is not, please explain why.
(Details)
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
This PR adds in checkpoints for SAM2.1 models into the FiftyOne Model zoo.
What areas of FiftyOne does this PR affect?
fiftyonePython library changesSummary by CodeRabbit